File size: 11,308 Bytes
064bfd6 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 | import type { LspServerConfig } from '../services/lsp/types.js'
import type { McpServerConfig } from '../services/mcp/types.js'
import type { BundledSkillDefinition } from '../skills/bundledSkills.js'
import type {
CommandMetadata,
PluginAuthor,
PluginManifest,
} from '../utils/plugins/schemas.js'
import type { HooksSettings } from '../utils/settings/types.js'
export type { PluginAuthor, PluginManifest, CommandMetadata }
/**
* Definition for a built-in plugin that ships with the CLI.
* Built-in plugins appear in the /plugin UI and can be enabled/disabled by
* users (persisted to user settings).
*/
export type BuiltinPluginDefinition = {
/** Plugin name (used in `{name}@builtin` identifier) */
name: string
/** Description shown in the /plugin UI */
description: string
/** Optional version string */
version?: string
/** Skills provided by this plugin */
skills?: BundledSkillDefinition[]
/** Hooks provided by this plugin */
hooks?: HooksSettings
/** MCP servers provided by this plugin */
mcpServers?: Record<string, McpServerConfig>
/** Whether this plugin is available (e.g. based on system capabilities). Unavailable plugins are hidden entirely. */
isAvailable?: () => boolean
/** Default enabled state before the user sets a preference (defaults to true) */
defaultEnabled?: boolean
}
export type PluginRepository = {
url: string
branch: string
lastUpdated?: string
commitSha?: string
}
export type PluginConfig = {
repositories: Record<string, PluginRepository>
}
export type LoadedPlugin = {
name: string
manifest: PluginManifest
path: string
source: string
repository: string // Repository identifier, usually same as source
enabled?: boolean
isBuiltin?: boolean // true for built-in plugins that ship with the CLI
sha?: string // Git commit SHA for version pinning (from marketplace entry source)
commandsPath?: string
commandsPaths?: string[] // Additional command paths from manifest
commandsMetadata?: Record<string, CommandMetadata> // Metadata for named commands from object-mapping format
agentsPath?: string
agentsPaths?: string[] // Additional agent paths from manifest
skillsPath?: string
skillsPaths?: string[] // Additional skill paths from manifest
outputStylesPath?: string
outputStylesPaths?: string[] // Additional output style paths from manifest
hooksConfig?: HooksSettings
mcpServers?: Record<string, McpServerConfig>
lspServers?: Record<string, LspServerConfig>
settings?: Record<string, unknown>
}
export type PluginComponent =
| 'commands'
| 'agents'
| 'skills'
| 'hooks'
| 'output-styles'
/**
* Discriminated union of plugin error types.
* Each error type has specific contextual data for better debugging and user guidance.
*
* This replaces the previous string-based error matching approach with type-safe
* error handling that can't break when error messages change.
*
* IMPLEMENTATION STATUS:
* Currently used in production (2 types):
* - generic-error: Used for various plugin loading failures
* - plugin-not-found: Used when plugin not found in marketplace
*
* Planned for future use (10 types - see TODOs in pluginLoader.ts):
* - path-not-found, git-auth-failed, git-timeout, network-error
* - manifest-parse-error, manifest-validation-error
* - marketplace-not-found, marketplace-load-failed
* - mcp-config-invalid, hook-load-failed, component-load-failed
*
* These unused types support UI formatting and provide a clear roadmap for
* improving error specificity. They can be incrementally implemented as
* error creation sites are refactored.
*/
export type PluginError =
| {
type: 'path-not-found'
source: string
plugin?: string
path: string
component: PluginComponent
}
| {
type: 'git-auth-failed'
source: string
plugin?: string
gitUrl: string
authType: 'ssh' | 'https'
}
| {
type: 'git-timeout'
source: string
plugin?: string
gitUrl: string
operation: 'clone' | 'pull'
}
| {
type: 'network-error'
source: string
plugin?: string
url: string
details?: string
}
| {
type: 'manifest-parse-error'
source: string
plugin?: string
manifestPath: string
parseError: string
}
| {
type: 'manifest-validation-error'
source: string
plugin?: string
manifestPath: string
validationErrors: string[]
}
| {
type: 'plugin-not-found'
source: string
pluginId: string
marketplace: string
}
| {
type: 'marketplace-not-found'
source: string
marketplace: string
availableMarketplaces: string[]
}
| {
type: 'marketplace-load-failed'
source: string
marketplace: string
reason: string
}
| {
type: 'mcp-config-invalid'
source: string
plugin: string
serverName: string
validationError: string
}
| {
type: 'mcp-server-suppressed-duplicate'
source: string
plugin: string
serverName: string
duplicateOf: string
}
| {
type: 'lsp-config-invalid'
source: string
plugin: string
serverName: string
validationError: string
}
| {
type: 'hook-load-failed'
source: string
plugin: string
hookPath: string
reason: string
}
| {
type: 'component-load-failed'
source: string
plugin: string
component: PluginComponent
path: string
reason: string
}
| {
type: 'mcpb-download-failed'
source: string
plugin: string
url: string
reason: string
}
| {
type: 'mcpb-extract-failed'
source: string
plugin: string
mcpbPath: string
reason: string
}
| {
type: 'mcpb-invalid-manifest'
source: string
plugin: string
mcpbPath: string
validationError: string
}
| {
type: 'lsp-config-invalid'
source: string
plugin: string
serverName: string
validationError: string
}
| {
type: 'lsp-server-start-failed'
source: string
plugin: string
serverName: string
reason: string
}
| {
type: 'lsp-server-crashed'
source: string
plugin: string
serverName: string
exitCode: number | null
signal?: string
}
| {
type: 'lsp-request-timeout'
source: string
plugin: string
serverName: string
method: string
timeoutMs: number
}
| {
type: 'lsp-request-failed'
source: string
plugin: string
serverName: string
method: string
error: string
}
| {
type: 'marketplace-blocked-by-policy'
source: string
plugin?: string
marketplace: string
blockedByBlocklist?: boolean // true if blocked by blockedMarketplaces, false if not in strictKnownMarketplaces
allowedSources: string[] // Formatted source strings (e.g., "github:owner/repo")
}
| {
type: 'dependency-unsatisfied'
source: string
plugin: string
dependency: string
reason: 'not-enabled' | 'not-found'
}
| {
type: 'plugin-cache-miss'
source: string
plugin: string
installPath: string
}
| {
type: 'generic-error'
source: string
plugin?: string
error: string
}
export type PluginLoadResult = {
enabled: LoadedPlugin[]
disabled: LoadedPlugin[]
errors: PluginError[]
}
/**
* Helper function to get a display message from any PluginError
* Useful for logging and simple error displays
*/
export function getPluginErrorMessage(error: PluginError): string {
switch (error.type) {
case 'generic-error':
return error.error
case 'path-not-found':
return `Path not found: ${error.path} (${error.component})`
case 'git-auth-failed':
return `Git authentication failed (${error.authType}): ${error.gitUrl}`
case 'git-timeout':
return `Git ${error.operation} timeout: ${error.gitUrl}`
case 'network-error':
return `Network error: ${error.url}${error.details ? ` - ${error.details}` : ''}`
case 'manifest-parse-error':
return `Manifest parse error: ${error.parseError}`
case 'manifest-validation-error':
return `Manifest validation failed: ${error.validationErrors.join(', ')}`
case 'plugin-not-found':
return `Plugin ${error.pluginId} not found in marketplace ${error.marketplace}`
case 'marketplace-not-found':
return `Marketplace ${error.marketplace} not found`
case 'marketplace-load-failed':
return `Marketplace ${error.marketplace} failed to load: ${error.reason}`
case 'mcp-config-invalid':
return `MCP server ${error.serverName} invalid: ${error.validationError}`
case 'mcp-server-suppressed-duplicate': {
const dup = error.duplicateOf.startsWith('plugin:')
? `server provided by plugin "${error.duplicateOf.split(':')[1] ?? '?'}"`
: `already-configured "${error.duplicateOf}"`
return `MCP server "${error.serverName}" skipped — same command/URL as ${dup}`
}
case 'hook-load-failed':
return `Hook load failed: ${error.reason}`
case 'component-load-failed':
return `${error.component} load failed from ${error.path}: ${error.reason}`
case 'mcpb-download-failed':
return `Failed to download MCPB from ${error.url}: ${error.reason}`
case 'mcpb-extract-failed':
return `Failed to extract MCPB ${error.mcpbPath}: ${error.reason}`
case 'mcpb-invalid-manifest':
return `MCPB manifest invalid at ${error.mcpbPath}: ${error.validationError}`
case 'lsp-config-invalid':
return `Plugin "${error.plugin}" has invalid LSP server config for "${error.serverName}": ${error.validationError}`
case 'lsp-server-start-failed':
return `Plugin "${error.plugin}" failed to start LSP server "${error.serverName}": ${error.reason}`
case 'lsp-server-crashed':
if (error.signal) {
return `Plugin "${error.plugin}" LSP server "${error.serverName}" crashed with signal ${error.signal}`
}
return `Plugin "${error.plugin}" LSP server "${error.serverName}" crashed with exit code ${error.exitCode ?? 'unknown'}`
case 'lsp-request-timeout':
return `Plugin "${error.plugin}" LSP server "${error.serverName}" timed out on ${error.method} request after ${error.timeoutMs}ms`
case 'lsp-request-failed':
return `Plugin "${error.plugin}" LSP server "${error.serverName}" ${error.method} request failed: ${error.error}`
case 'marketplace-blocked-by-policy':
if (error.blockedByBlocklist) {
return `Marketplace '${error.marketplace}' is blocked by enterprise policy`
}
return `Marketplace '${error.marketplace}' is not in the allowed marketplace list`
case 'dependency-unsatisfied': {
const hint =
error.reason === 'not-enabled'
? 'disabled — enable it or remove the dependency'
: 'not found in any configured marketplace'
return `Dependency "${error.dependency}" is ${hint}`
}
case 'plugin-cache-miss':
return `Plugin "${error.plugin}" not cached at ${error.installPath} — run /plugins to refresh`
}
}
|